Implement Hooks and DI #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldadfux
reviewed
Sep 7, 2022
eldadfux
reviewed
Sep 8, 2022
eldadfux
requested changes
Oct 16, 2022
| */ | ||
| public function stop(): self | ||
| { | ||
| try { |
Member
There was a problem hiding this comment.
Should we have the same try catch block for all start/shutdown/init/stop methods?
| * Waiting for next Job. | ||
| */ | ||
| $nextJob = $this->adapter->connection->rightPopArray("{$this->adapter->namespace}.queue.{$this->adapter->queue}", 5); | ||
| $nextMessage = $this->adapter->connection->rightPopArray("{$this->adapter->namespace}.queue.{$this->adapter->queue}", 5); |
Member
There was a problem hiding this comment.
This line seems a bit problematic, is this coupled with Swoole? who is providing rightPopArray?
What is the number 5?
Contributor
Author
There was a problem hiding this comment.
@TorstenDittmann I've not idea about this :(
eldadfux
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.