Skip to content

fix(amqp): properly close connection on errors and open clean, new connection #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christyjacob4 merged 1 commit into from
Feb 10, 2025
Merged

fix(amqp): properly close connection on errors and open clean, new connection #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Queue/Broker/AMQP.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,15 +189,16 @@ private function withChannel(callable $callback): void
return $channel;
};

if ($this->channel == null) {
if (!$this->channel) {
$this->channel = $createChannel();
}

try {
$callback($this->channel);
} catch (\Throwable $th) {
// try to create a new connection once
unset($this->channel);
// createChannel() might throw, in that case set the channel to `null` first.
$this->channel = null;
// try creating a new connection once, if this still fails, throw the error
$this->channel = $createChannel();
$callback($this->channel);
}
Expand Down