Transfer functionality to transfer file from one device to another #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meldiron
reviewed
Mar 15, 2022
eldadfux
requested changes
May 22, 2022
Member
eldadfux
left a comment
eldadfux
left a comment
There was a problem hiding this comment.
Left a few comments. Do we need to adjust the new adapters as well?
src/Storage/Device/S3.php
Outdated
| * | ||
| * @return bool | ||
| */ | ||
| public function move(string $source, string $target): bool |
Member
There was a problem hiding this comment.
With this new implementation, could we move the move method implementation to the abstract class and avoid from implementing it in each adapter?
fogelito
approved these changes
Aug 8, 2023
refactor test
abnegate
approved these changes
Aug 15, 2023
eldadfux
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.