Chore: Replace assertEquals with assertSame

[Meldiron]

Summary by CodeRabbit

• Tests
  • Enhanced test assertion rigor by implementing stricter type and value comparisons across VCS adapter and base test suites. These changes strengthen test validation without affecting functionality or test coverage.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Warning

Rate limit exceeded

@Meldiron has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 28 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 32c9f73 and 4b6ed63.

📒 Files selected for processing (1)

• tests/VCS/Adapter/GitHubTest.php (11 hunks)

Walkthrough

This pull request updates test assertions across two VCS test files. In tests/VCS/Adapter/GitHubTest.php, multiple assertEquals() calls are replaced with assertSame() for strict equality comparisons. Similarly, in tests/VCS/Base.php, three assertEquals() assertions are replaced with assertSame() when comparing string owner names, repository full names, and boolean deletion results. No test logic, data, or control flow is modified—only the assertion comparison methods change from loose to strict equality checking.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Homogeneous, repetitive changes applied consistently across 2 test files
• No logic modifications or control flow changes
• Pure assertion method replacements with predictable patterns
• Limited scope confined to test files only

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 6.25% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the primary change: replacing loose equality assertions (assertEquals) with strict assertions (assertSame) across test files.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28457cf and 32c9f73.

📒 Files selected for processing (2)

• tests/VCS/Adapter/GitHubTest.php (11 hunks)
• tests/VCS/Base.php (3 hunks)

🧰 Additional context used

🧬 Code graph analysis (2)

tests/VCS/Base.php (2)

src/VCS/Adapter.php (1)

• createRepository (109-109)

src/VCS/Adapter/Git/GitHub.php (1)

• createRepository (85-95)

tests/VCS/Adapter/GitHubTest.php (1)

src/VCS/Adapter/Git/GitHub.php (4)

• getEvent (621-715)
• getRepositoryTree (167-178)
• getRepositoryContent (209-238)
• getLatestCommit (515-540)

🪛 GitHub Actions: Tests

tests/VCS/Adapter/GitHubTest.php

[error] 126-126: PHPUnit failure: assertion that '1234' (string) is identical to 1234 (int) failed in GitHubTest::testgetEvent. Consider casting or comparing with == or adjust expected type.

🔇 Additional comments (2)

tests/VCS/Base.php (1)

49-49: Strict assertions here look correct

The switch to assertSame for the owner name, directory size, repository full_name, and delete result uses clearly-typed literals (string/int/bool) that match the intended behavior and should help catch accidental type changes in the adapter.

Also applies to: 122-123, 129-130, 138-141

tests/VCS/Adapter/GitHubTest.php (1)

117-123: Good move to strict comparisons across these tests

Using assertSame for branches, IDs, paths, content, exit codes, and commit metadata tightens the tests without changing intent and should make type regressions more visible. I don’t see any other type-mismatch risks in these conversions based on the literals and fixtures in use.

Also applies to: 141-145, 169-182, 189-206, 284-291, 301-303, 315-317, 329-331, 340-342, 379-392