Skip to content

fix: update dart commads #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christyjacob4 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: update dart commads #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Detector/Adapter/Dart.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@ public function getFiles(): array

public function getInstallCommand(): string
{
return 'flutter pub get';
return 'dart pub get';
Copy link
Contributor

@vermakhushboo vermakhushboo Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm able to verify dart pub get but not dart build. I found dart run and webdev build --output web:build instead in the docs. @Meldiron @stnguyen90 any idea?

Copy link
Contributor

@Meldiron Meldiron Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually dont use these methods for install and build commands I think. Right?

Copy link
Contributor

@Meldiron Meldiron Sep 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have some in installation: https://github.com/appwrite/appwrite/blob/master/src/Appwrite/Migration/Version/V19.php#L629

}

public function getBuildCommand(): string
{
return 'flutter build';
return 'dart build';
Copy link

@stnguyen90 stnguyen90 Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be something like dart compile. See https://github.com/open-runtimes/open-runtimes/blob/b6450aca19f6e95c319ba973422857610b718d3b/runtimes/dart-2.16/helpers/after-build.sh#L16

}

public function getEntryPoint(): string
Expand Down