Fix: get commit missing details

[Meldiron]

Summary by CodeRabbit

• Bug Fixes
  • Improved GitHub integration resilience: commit information retrieval now tolerates missing metadata and uses sensible defaults (e.g., unknown author or message, empty avatar/URL) instead of failing, ensuring more reliable display and processing of commit details.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The getCommit method in GitHub.php was changed to use intermediate variables for body, author, commit, and commitAuthor instead of directly accessing nested response fields. The previous runtime check that threw when author or message data was missing was removed. Missing fields now return defaults: commitAuthor => "Unknown", commitMessage => "No message", and avatar, author URL, commit hash, and commit URL default to empty strings when absent.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: fixing the getCommit method to handle missing details by providing defaults instead of throwing errors.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 44035d3 and e4cbdde.

📒 Files selected for processing (1)

• src/VCS/Adapter/Git/GitHub.php

[Copilot]

Pull request overview

This pull request improves the resilience of the GitHub commit retrieval by replacing exception-based error handling with defensive programming using default values. The getCommit method now gracefully handles missing commit metadata from the GitHub API response instead of throwing exceptions.

Key Changes:

• Removed validation that threw exceptions for missing commit author or message fields
• Applied null coalescing operators throughout to provide sensible defaults for all response fields
• Returns 'Unknown' for missing author names, 'No message' for missing commit messages, and empty strings for optional URL fields

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/VCS/Adapter/Git/GitHub.php (1)

497-509: Consider aligning error handling with getLatestCommit.

The getCommit method now returns defaults for missing fields, while getLatestCommit (lines 526-535) throws an exception when required fields are missing. This creates an inconsistency in error handling behavior across similar methods.

Consider whether:

1. Both methods should fail fast with exceptions for missing critical fields, OR
2. Both methods should be resilient and return defaults

The resilient approach (current implementation) is beneficial for edge cases like deleted users or system commits, but callers may prefer to know when data is incomplete rather than receiving default values.

Would you like me to generate a script to verify if there are other methods in the codebase that handle commit data, to ensure consistent error handling across all of them?

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e4cbdde and 62491de.

📒 Files selected for processing (1)

• src/VCS/Adapter/Git/GitHub.php

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Agent

🔇 Additional comments (1)

src/VCS/Adapter/Git/GitHub.php (1)

497-509: The field mapping issue has been resolved!

The previous critical issue regarding incorrect field mapping for avatar_url and html_url has been fixed. The code now correctly:

• Retrieves the GitHub user object from $body['author'] (line 498)
• Uses this for commitAuthorAvatar and commitAuthorUrl (lines 505-506)
• Retrieves the Git commit author from $commit['author'] (line 500)
• Uses this for commitAuthor name (line 503)

This aligns with the GitHub API structure where response.body.author contains the GitHub user fields (avatar_url, html_url) and response.body.commit.author contains the Git commit author fields (name, email, date).