test: add initial unit tests#38
Merged
Mercurial merged 3 commits intoutxorpc:mainfrom Mar 16, 2025
Merged
Conversation
SebastienGllmt
commented
Mar 15, 2025
Comment on lines
+134
to
+135
| // TODO: this is missing for some reason | ||
| // height: "0", |
Contributor
Author
There was a problem hiding this comment.
fields equal to the default value for the data type seem to be missing if you call toJson, so I think this is probably a bug in the toJson implementation (these fields are not optional)
Either that, or these are purposely left out as a performance improvement when sending data over the wire, and there is a separate way you're support to JSONify these objects when you care about getting the full object properly
Mercurial
approved these changes
Mar 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds unit tests to the project
There were some I didn't add because it requires creating a mock utxorpc backend. The ones I did add are instead populated with static data from creating a localhost network with yaci-devkit + dolos