Skip to content

fix: add missing exports with Cardano prefix #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mercurial merged 1 commit into from
Mar 16, 2025
Merged

fix: add missing exports with Cardano prefix #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,18 @@ export {
QueryClient as CardanoQueryClient,
SubmitClient as CardanoSubmitClient,
WatchClient as CardanoWatchClient,
ChainPoint as CardanoChainPoint,
Utxo as CardanoUtxo,
TipEvent as CardanoTipEvent,
TxEvent as CardanoTxEvent,
MempoolEvent as CardanoMempoolEvent,
TxHash as CardanoTxHash,
TxCbor as CardanoTxCbor,
Comment on lines +6 to +12
Copy link
Copy Markdown
Contributor Author

@SebastienGllmt SebastienGllmt Mar 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming you're fine with just re-exporting everything with a Cardano prefix

If you really don't like this, you could make that all the Cardano types are instead exported under @utxorpc/sdk/cardano using conditional exports, but given Cardano is the only chain supported at the moment it might not be worth spending time on this now

Copy link
Copy Markdown
Contributor

@Mercurial Mercurial Mar 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this, we can revisit later once we have more chains avaialble.

} from "./cardano.js";
export type {
ClientBuilderOptions,
GenericTipEvent,
GenericTxEvent,
GenericTxInMempoolEvent,
GenericUtxo,
} from "./common.js";