feat: update utxorpc-spec to 0.18.1#50
Merged
Mercurial merged 7 commits intoutxorpc:mainfrom Jan 26, 2026
Merged
Conversation
01836c0 to
626068a
Compare
Contributor
|
Thanks for the update! The changes look good overall. A few notes: Version BumpPer our historical pattern, version bumps should be in a separate PR/commit. Could you please remove the Looking at the repo history: Code ReviewThe rest of the changes look good:
Once the version bump is removed, this should be good to merge! |
Contributor
|
Minor style nit: missing trailing comma on line 175 for consistency with line 170: // line 170 (apply case)
nativeBytes: any.action.value.nativeBytes,
// line 175 (undo case) - missing trailing comma
nativeBytes: any.action.value.nativeBytes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the SDK to wrap a newer version of utxorpc-spec. This version includes some breaking changes:
I've also fixed the
watchTxForAssetfunction to correctly handle querying for policy ids without an explicit asset name.Note that the tests don't pass yet;
@utxorpc/blaze-provideralso needs to be updated to cope with the new spec version. I have that update written locally, and all tests pass with that update (though the SubmitTX tests fail when you run them all at once, thanks to wallet contention).Warning: Breaking Change
This new utxorpc-spec version is not backwards-compatible with the old one. Demeter currently supports utxorpc-spec
0.17.0, and this node-sdk version won't work with it. Once demeter is updated to0.18.1, this version will work, but the old one won't work anymore. There isn't really a way for demeter-backed projects to gracefully transition.