runcon: add missing utilities to enable tests/runcon/runcon-compute and removing PATH from runcon -c#10088
Merged
sylvestre merged 1 commit intouutils:mainfrom Jan 7, 2026
Conversation
1bb02d9 to
fa6797e
Compare
|
GNU testsuite comparison: |
… -c PATH behavior
fa6797e to
3078a6e
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two issues here, the test uses chmod to setup the test and because it was symlinked to false it made the test fail with an error code that indicated that the setup for the test had failed.
Then the second problem is that the way exec was called would use binaries in the PATH. The test does not want to follow this behaviour so the way it gets around this is by adding a ./ to the beginning of the pathbuf for the command so that it will not search first for the binary in the PATH.
This makes the runcon-no-compute gnu test succeed. This test used to pass before when runcon was symlinked to false so we were not aware of this issue until now.