Merged
Conversation
Simplify the function by computing mode_count directly and using early returns instead of accumulating a counter with nested if statements.
sylvestre
force-pushed
the
10068-followup
branch
from
a4d2375 to
6ed0f08
Compare
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging this PR will improve performance by 4.39%Comparing Summary
Performance Changes
Footnotes
|
cakebaker
reviewed
Jan 14, 2026
Comment on lines
+514
to
+517
| let mode_count = u8::from(flags.numeric) | ||
| + u8::from(flags.general_numeric) | ||
| + u8::from(flags.human_numeric) | ||
| + u8::from(flags.month); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.