chore: add test for setgid bit inheritance in mkdir -p#10412
Merged
ChrisDryden merged 1 commit intouutils:mainfrom Jan 22, 2026
Merged
chore: add test for setgid bit inheritance in mkdir -p#10412ChrisDryden merged 1 commit intouutils:mainfrom
ChrisDryden merged 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
Collaborator
|
Was doing some investigating into why the macos and bsd builds are failing and it appears that for those systems automatic setgid inheritance doesn't happen at the kernel level. We would have to implement it in the create_single_dir function to see if the parent directory has setgid and explicitly add it. For now you can just change the test from: With a to-do, its still good to have a regression test for the functionality we have even if its not complete, but would probably be good to open an issue about it |
Contributor
Author
|
that is interesting to know |
df85eb2 to
4dcd2a5
Compare
|
GNU testsuite comparison: |
mattsu2020
pushed a commit
to mattsu2020/coreutils
that referenced
this pull request
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wasn't working before #10036, so I thought adding test would be better to prevent this in future. See #10036 (comment).