uniq: fix -w to count bytes in C locale#11061
Merged
cakebaker merged 3 commits intouutils:mainfrom Feb 23, 2026
Merged
Conversation
|
GNU testsuite comparison: |
xtqqczze
reviewed
Feb 23, 2026
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
abendrothj
pushed a commit
to abendrothj/coreutils
that referenced
this pull request
Feb 23, 2026
* uniq: fix -w to count bytes in C locale * uniq: add CTYPE to spellchecker ignore list * uniq: avoid String allocation by using std::env::var_os()
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uniq -w Nshould count bytes in C/POSIX locale and characters in UTF-8 locale. Currently it always counts UTF-8 characters regardless of locale.Changes
is_c_locale()helper that checksLC_ALL,LC_CTYPE,LANGin orderkey_end_index()to use byte counting when in C localetest_stdin_w1_multibyteto explicitly set UTF-8 locale (it was implicitly relying on character counting)Considerations
I chose to inline the locale check (~9 lines) rather than adding the
i18nfeature dependency. The check is simple enough that duplicating it seemed better than pulling in ICU dependencies just for this.If you'd prefer I use
uucore::i18ninstead, let me know and I'll update.Fixes #10184