wc: optimize -c when reading from stdin regular file#11715
Open
venoosoo wants to merge 7 commits intouutils:mainfrom
Open
wc: optimize -c when reading from stdin regular file#11715venoosoo wants to merge 7 commits intouutils:mainfrom
venoosoo wants to merge 7 commits intouutils:mainfrom
Conversation
oech3
reviewed
Apr 8, 2026
tests/by-util/test_wc.rs
Outdated
| .succeeds() | ||
| .stdout_is("50000000\n"); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
This should be part of benchmark
Contributor
There was a problem hiding this comment.
But I don't know how to use stdin at CodSpeed. Maybe, you can just drop the test.
|
GNU testsuite comparison: |
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #11610
This PR adds the missing metadata optimization for
wc -c(and--bytes) when input comes from stdin redirection (wc -c < file).GNU coreutils uses
fstat()to get the file size directly in this case, avoiding reading the entire file. uutils previously always read the data, making it very slow on large files.Changes
try_get_stdin_size()helper usingrustix::fs::fstat(Unix)also didnt really know windows so i just added todo to windows implementation