factor: Add/update copyright notices as necessary#1546
Merged
Conversation
Copyright lines were moved from factor.rs to match where code was moved to.
Contributor
|
I am clearly not a fan for having a list of contributors in header (too strong sense of ownership, when do we add names, etc). we should have a global author file at the root directory. |
Contributor
Author
Yes, this is not my preferred solution either, but having it partially-there was strictly worse (and changing this convention for the entire project felt waaay outside my remit.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered yesterday that I accidentally failed to update/preserve those when
moving code around (#1525), deleting code (#1529), or adding my own
contributions.
This rectifies it, also adding years (based on git history) for all copyright
lines; I took the liberty not to track the individual changes for which
copyright is claimed, since that information is in git and tacking it by hand
would get out-of-hand very quickly.