perf/factor ~ deduplicate divisors#1571

Closed

nicoonoclaste wants to merge 19 commits into

uutils:masterfrom

nicoonoclaste:factor/faster/dedup_primes

Commits on Oct 11, 2020

factor: Introduce a type alias for exponents

nicoonoclaste
authored and
rivy
committed
factor::Factors: Split off a Decomposition type

nicoonoclaste
authored and
rivy
committed
factor::Decomposition: Use a flat vector representation

nicoonoclaste
authored and
rivy
committed
factor::Factors: Use a RefCell rather than copy data when printing

nicoonoclaste
authored and
rivy
committed
factor: Derecursify and refactor

nicoonoclaste
authored and
rivy
committed
factor: Ensure we only need to find every single factor once [WiP]

nicoonoclaste
authored and
rivy
committed
factor::Decomposition: Optimise as a factor is never added twice

nicoonoclaste
authored and
rivy
committed
factor: Slightly refactor main loop, fix bug

nicoonoclaste
authored and
rivy
committed
factor::Decomposition: Inline a small number (4) of factors

nicoonoclaste
authored and
rivy
committed
factor/refactor ~ fix `cargo clippy` complaints (allow many_single_char_names)
rivy
committed
tests/factor ~ update RNG usage and variable reports to ease debugging
rivy
committed
tests ~ (sub-crate/factor) add tests for known prior factorization failures
rivy
committed
fix/factor ~ fix fault when factoring number composed of a squared factor
rivy
committed
perf/factor ~ improve factor() quotient and loop comparison (~6% time improvement)
rivy
committed
perf/factor ~ tune number of stack inlined decomposition values (~1% time improvement)
rivy
committed
tests/factor ~ test first 100000 integers for expected results
rivy
committed
polish/factor ~ correct spelling
rivy
committed
tests ~ (sub-crate factor) refactor divisor() test for improved readability
rivy
committed
tests/factor ~ refactor for readability + improve DRY
rivy
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

perf/factor ~ deduplicate divisors#1571

perf/factor ~ deduplicate divisors#1571
nicoonoclaste wants to merge 19 commits into
uutils:masterfrom
nicoonoclaste:factor/faster/dedup_primes

Commits on Oct 11, 2020

factor: Introduce a type alias for exponents

factor::Factors: Split off a Decomposition type

factor::Decomposition: Use a flat vector representation

factor::Factors: Use a RefCell rather than copy data when printing

factor: Derecursify and refactor

factor: Ensure we only need to find every single factor once [WiP]

factor::Decomposition: Optimise as a factor is never added twice

factor: Slightly refactor main loop, fix bug

factor::Decomposition: Inline a small number (4) of factors

factor/refactor ~ fix `cargo clippy` complaints (allow many_single_char_names)

tests/factor ~ update RNG usage and variable reports to ease debugging

tests ~ (sub-crate/factor) add tests for known prior factorization failures

fix/factor ~ fix fault when factoring number composed of a squared factor

perf/factor ~ improve factor() quotient and loop comparison (~6% time improvement)

perf/factor ~ tune number of stack inlined decomposition values (~1% time improvement)

tests/factor ~ test first 100000 integers for expected results

polish/factor ~ correct spelling

tests ~ (sub-crate factor) refactor divisor() test for improved readability

tests/factor ~ refactor for readability + improve DRY