Disable the GNU tests in CI#2224
Closed
nicoonoclaste wants to merge 1 commit into
Closed
Conversation
Those are routinely broken on `master` and should not be run as part of CI until they are fixed. Broken CI is worse than no CI, as it teaches people to ignore errors.
Contributor
|
Sorry but I don't agree. They are working most of the time. There is just a new issue which need to be fixed. Not the CI to be disabled |
Contributor
Author
|
@sylvestre What's the solution then? Since those tests got added, half of my (merged) PRs ran into this thing being broken, and every time it consumes a bunch of my (very limited) time and energy to check that it's indeed unrelated to my changes. See #2143 and #1842, where I already raised that issue and pointed out the “GNU tests” are taken directly from coreutils/coreutils' |
Contributor
|
Just ignore them, it is that easy ;) |
Contributor
|
I am trying this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those are routinely broken on
masterand should not be run as part of CI until they are fixed.Broken CI is worse than no CI, as it teaches people to ignore errors.