CI: Stabilise the version of GNU tests used in CI#2226
Merged
Conversation
The “GNU tests” task is routinely broken on `master`. Broken CI is worse than no CI, as it teaches people to ignore errors. This PR pins the versions of the GNU testsuite (and GNUlib) used, to current stable versions, so this task stops breaking unexpectedly. Presumably, someone will update `GNU.yml` when a new stable version of the GNU coreutils is released, but I'm not volunteering.
sylvestre
reviewed
May 17, 2021
| repository: 'coreutils/coreutils' | ||
| path: 'gnu' | ||
| - name: Chechout GNU corelib | ||
| ref: v8.32 |
Contributor
There was a problem hiding this comment.
8.32 and the ref are both necessary?
Contributor
Author
There was a problem hiding this comment.
Yes. v8.32 applies to coreutils/coreutils, whereas the commit hash applies to the GNUlib repo.
Unfortunately, the latter doesn't seem to have git tags for current stable releases, hence the use of a commit hash for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The “GNU tests” task is routinely broken on
master.Broken CI is worse than no CI, as it teaches people to ignore errors.
This PR pins the versions of the GNU testsuite (and GNUlib) used,
to current stable versions, so this task stops breaking unexpectedly.
This is a proposed alternative to #2225.
Presumably, someone will update
GNU.ymlwhen a new stable versionof the GNU coreutils is released, but I'm not volunteering.