Conversation
Contributor
|
Excellent and looks great. Do you think it would be possible to add a check in the CI to prevent this from happening? |
Collaborator
Author
|
@sylvestre this is not 100% building on Redox yet, because of awaiting upstream crate releases for filetime and termsize. When that is done, I can add the CI test required |
Contributor
|
Excellent, thanks |
Collaborator
Author
|
Here was the commit getting it working 100%, but at the cost of having to patch some crates: https://gitlab.redox-os.org/redox-os/uutils/-/commit/cfb9f9bc594395edc3afe442889506efa169e158 |
Contributor
|
@jackpot51 I hope you are doing great. Do you know if we could have redox in the CI now ? :) |
sylvestre
added a commit
that referenced
this pull request
Apr 20, 2022
We have windows stable in the CI: https://github.com/uutils/coreutils/runs/6082164374?check_suite_focus=true And no longer Redox: #2550
Collaborator
Author
|
I will have to check if filetime and termsize ever got updated |
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains a number of small fixes for Redox support. It should not affect other platforms, at all. After this, there are still some minor fixes I am waiting on other crates to implement before Redox builds could be enabled in CI.
I have organized the changes into small commits, please view and evaluate each commit by itself if the whole patchset does not make sense.