test/util: improve run_ucmd_as_root for CICD

[jhscheer]

Ensure that fn run_no_wait is only invoked if the system running the
test has sudo in $path

Previously, if run inside CICD, calling fn run_ucmd_as_root
would provoke fn run_no_wait to panic because there's no sudo.

Can be tested locally with:

cargo test test_run_ucmd_as_root --features "whoami" --no-default-features -- --show-output --nocapture

(I don't know why all the old commits popped up here !?)

[sylvestre]

I guess you saw:
#3515 ;)

[jhscheer]

I guess you saw: #3515 ;)

Ah okay, I'll try to investigate that cannot open: Permission denied issue.

[sylvestre]

@jhscheer Should I land #3515 now or you can fix it quickly?

[jhscheer]

The checks for this PR look good now, however I had to wrap everything in if !is_ci() to get rid of this strange permission issue.

@jhscheer Should I land #3515 now or you can fix it quickly?

I think #3515 can be closed in favor of this.

[sylvestre]

So, I guess the failure

---- test_sort::test_version_empty_lines stdout ----
current_directory_resolved: 
run: D:\a\coreutils\coreutils\target\debug\coreutils.exe sort version-empty-lines.txt -V
open: C:\Users\RUNNER~1\AppData\Local\Temp\.tmpGvU2a2\version-empty-lines.expected
current_directory_resolved: 
run: D:\a\coreutils\coreutils\target\debug\coreutils.exe sort version-empty-lines.txt --debug -V
---- test_sort::test_version_empty_lines stderr ----
thread 'main' panicked at 'Command was expected to succeed.
stdout = 
^ no match for key
^ no match for key

^ no match for key
^ no match for key

^ no match for key
^ no match for key

^ no match for key
^ no match for key

^ no match for key
^ no match for key

^ no match for key
^ no match for key

^ no match for key
^ no match for key
1.2.3-alpha
___________
___________
1.2.3-alpha2
____________
____________
11.2.3
______
______
bar2
____
____
bar2.0.0
________
________
foo0.1
______
______
foo1.0
______
______
>>>1.12.4
_________
_________

 stderr = ', tests\common\util.rs:174:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    test_sort::test_version_empty_lines

is unrelated?
thanks :)

[sylvestre]

I had to wrap everything in if !is_ci() to get rid of this strange permission issue.

I have seen some unexpected behavior too in the past

[jhscheer]

So, I guess the failure

failures:
    test_sort::test_version_empty_lines

is unrelated? thanks :)

Yes, that looks like an unrelated glitch.

[sylvestre]

yeah:

[jfinkels]

The documentation for GitHub Actions states that sudo is available. "When you need to execute commands or install tools that require more privileges than the current user, you can use sudo without needing to provide a password." https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#administrative-privileges-of-github-hosted-runners

So something odd is happening. Maybe PATH is not set when we spawn the process that is supposed to invoke sudo?