env: reraise signal from child process#4011
Merged
sylvestre merged 1 commit intouutils:mainfrom Oct 13, 2022
Merged
Conversation
ec3b780 to
ca820bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3188
This PR reraises any signals from the child process instead of printing them. This is more in line with GNU behaviour. The message that we previously printed was actually not GNU behaviour, but part of the shell.
I'm not sure how to test this in the CI. I need to spawn a child process that raises a signal to respond to. In normal testing I used a custom C program, but I'm not sure how to get that compiled in the CI: