ls: use libc::{major, minor} to calculate device number#4120
Merged
sylvestre merged 2 commits intouutils:mainfrom Nov 9, 2022
Merged
ls: use libc::{major, minor} to calculate device number#4120sylvestre merged 2 commits intouutils:mainfrom
sylvestre merged 2 commits intouutils:mainfrom
Conversation
sylvestre
reviewed
Nov 9, 2022
Contributor
|
I love simplifications :) |
09d30e9 to
2bb75a9
Compare
sylvestre
reviewed
Nov 9, 2022
|
GNU testsuite comparison: |
Contributor
Author
|
Test Android builds (28, default, x86) failed on a failures:
---- test_cp::test_cp_parents_2_dirs stdout ----
current_directory_resolved:
mkdir_all: /data/data/com.termux/files/usr/tmp/.tmp1DCT2X/a/b/c
mkdir: /data/data/com.termux/files/usr/tmp/.tmp1DCT2X/d
run: /data/data/com.termux/files/home/coreutils/target/debug/coreutils cp -a --parents a/b/c d
thread 'test_cp::test_cp_parents_2_dirs' panicked at 'Command was expected to succeed.
stdout =
stderr = cp: Permission denied (os error 13)
', tests/common/util.rs:176:9
failures:
test_cp::test_cp_parents_2_dirs
test result: FAILED. 2325 passed; 1 failed; 31 ignored; 0 measured; 0 filtered out; finished in 215.43s
error: test failed, to rerun pass `--test tests`
error: 1 target failed:
`--test tests`
Error: The process '/bin/sh' failed with exit code 101And sadly I have no idea about the failure in Run GNU tests... |
Contributor
|
both of them aren't your fault ... noise :( |
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the time of #2145,
majorandminorhave not been added to libc, so we have to manually calculate the device number.And those functions have been added (rust-lang/libc#2937) so that we can employ them.
BTW, I called
cargo fmton this file, but I didn't seerustfmt.tomlin this project, so if you guys don't like it, feel free to ask to to discard the format changes.Ref: #2140