tests/util: Don't trim output in CmdResult::stdout_matches and stdout_does_not_match#4304
Merged
tertsdiepraam merged 2 commits intouutils:mainfrom Feb 16, 2023
Conversation
Joining7943
force-pushed
the
tests-util-cmdresult-do-not-trim-output
branch
from
f7aa788 to
f535b38
Compare
…_does_not_match. Fix tests. The tests are fixed to match the trailing newline instead of ignoring it.
Joining7943
force-pushed
the
tests-util-cmdresult-do-not-trim-output
branch
from
f535b38 to
bbc25a0
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like discussed in #4261, this pr removes the trimming of the
stdoutinCmdResult::stdout_matchesandCmdResult::stdout_does_not_match.The tests using these methdos are adjusted to match the trailing newline instead of ignoring it.