remove utf8 dependency.

[publicmatt]

First time contributor. I wanted to help so I plucked an issue with the "good first issue" tag.

This commit addresses #4289

Summary:

The author of one of the wc dependencies opened an issue stating that the crate and repo were being deprecated. They suggested incorporating what was needed into coreutils directly and removing the dependency. I incorporated and built uu_wc which should fix this issue.

Of note: there are a few 'unused' warnings in the incorporated code - should I try to remove that as well?

[sylvestre]

could you please also fix the clippy warnings?
thanks
(in a different commit - ie don't force push)

[tertsdiepraam]

@sylvestre what's your opinion on the unused code? I think we should delete it if we're not using it.

[sylvestre]

as we are forking the lib, yes

[SimonSapin]

FWIW this is what I meant by "relevant code" in #4289: copy the parts you actually use.

[tertsdiepraam]

Indeed! @publicmatt to answer this question then:

Of note: there are a few 'unused' warnings in the incorporated code - should I try to remove that as well?

Let's only use the relevant code like @SimonSapin suggests :)

[publicmatt]

That makes sense - thanks for the guidance.

[sylvestre]

@publicmatt do you have an update?

[publicmatt]

@publicmatt do you have an update?

I just pushed an update where I removed all dead code from the utf8 crate that was incorporated. I'm not sure what the merge process looks like - should I squash all those commits or does that happen with the pull request?

[tertsdiepraam]

should I squash all those commits or does that happen with the pull request?

We usually keep the commits, but we squash sometimes if a contributor made a mess of the history. So I'd be nice if you could clean those up. In this case I think 1 commit would suffice.

[publicmatt]

should I squash all those commits or does that happen with the pull request?

We usually keep the commits, but we squash sometimes if a contributor made a mess of the history. So I'd be nice if you could clean those up. In this case I think 1 commit would suffice.

Makes sense! I did the following to combine my mess of commits:

git reset --soft [last commit from main before I started working on this]
git commit -m "replace utf8 dependency"
git push --force

I think that's right??

[tertsdiepraam]

I usually use interactive rebase for this. But I think it's correct :)

[publicmatt]

Getting acquainted with all the checks - I'll fix them up and push again.

[sylvestre]

Needs rustfmt & clippy fixes please :)

[publicmatt]

I ran and fixed suggestions from: cargo fmt and cargo clippy and RUSTDOCFLAGS="-Dwarnings" cargo doc --features "feat_os_unix" --no-deps --workspace --document-private-items. These were all failing the checks last time.

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?