mv: decline of overwrite does not return an error

[Senshyi]

solves issue #4724

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/mv/i-1. tests/mv/i-1 is passing on 'main'. Maybe you have to rebase?

[cakebaker]

Thanks for your PR.

Unfortunately, it doesn't solve the issue entirely. While it removes the error message, it also changes the exit code from 1 to 0 (this is why I used echo $? in the ticket, to highlight that the exit code should be 1).

Here's a test case to reproduce the issue. Currently, it will fail while all existing tests pass:

#[test]
fn test_mv_interactive_with_dir_as_target() {
    let (at, mut ucmd) = at_and_ucmd!();

    let file = "test_mv_interactive_file";
    let target_dir = "target";

    at.mkdir(target_dir);
    at.touch(file);
    at.touch(format!("{target_dir}/{file}"));

    ucmd.arg(file)
        .arg(target_dir)
        .arg("-i")
        .pipe_in("n")
        .fails()
        .stderr_does_not_contain("cannot move")
        .no_stdout();
}

[cakebaker]

@KEEZII are you still working on this issue?

[cakebaker]

Closing this PR as it has been superseded by #4773