Update parse_datetime to 0.5.0

[u8sand]

Fix #5274
Fix #5307

[tertsdiepraam]

Cool! This conflicts with #5181, but we can rebase that once this is merged.

[u8sand]

Okay I believe the error is unrelated to this PR but do let me know.

In terms of coverage, I've had to introduce two new (likely rare) error paths--caused if atime/mtime cannot be converted to DateTime due to overflow. Do let me know if I should attempt to add tests for these, honestly I'm not to sure how it would be triggered, perhaps an a/mtime of INTMAX or INTMIN.

[u8sand]

So I do have a bit of a hacky fix for the new test

Which works in my terminal, but the test still fails with:

run: /home/u8sand/Programs/apps/coreutils/target/debug/coreutils touch -m -t +1000000000000 years test_touch_invalid_date_format
thread 'test_touch::test_touch_invalid_date_format' panicked at ''touch: invalid date format '+1000000000000 years'
' does not contain 'touch: invalid date format ‘+1000000000000 years’'', tests/by-util/test_touch.rs:855:10
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Not sure why the test suite changes the ticks to quotes? Please advise -- though I probably won't get back to this till next weekend 😞

In any-case, I made the test a bit easier 🤷‍♂️

[tertsdiepraam]

Ehh, I don't think that's a great idea 😄 This won't work with panic = "abort" for example. I think we need to fix parse_datetime instead. We don't need to match GNU's errors exactly. What's different?

[u8sand]

Yeah I figured, the panic is in Chrono itself. The commits are pretty contained so we can just drop b6c6cca

In terms of the error, touch seems to use directional quotes instead of single quotes.

[sylvestre]

we should contribute in chrono to remove the panic and returns error in general

[tertsdiepraam]

Oh the quotes are based on locale! We currently entirely ignore locale. If you run LC_ALL=C touch -d invalid foo you'll see the same quotes as uutils.

[sylvestre]

please ignore this test for now:

--- TRY 3 STDERR:        coreutils::tests test_touch::test_touch_invalid_date_format ---
thread 'test_touch::test_touch_invalid_date_format' panicked at ''touch: invalid date format '+1000000000000 years'
' does not contain 'touch: invalid date format ‘+1000000000000 years’'', tests/by-util/test_touch.rs:855:10
stack backtrace:
   0: rust_begin_unwind
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/panicking.rs:578:5
   1: core::panicking::panic_fmt
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:67:14
   2: tests::common::util::CmdResult::stderr_contains
             at ./tests/common/util.rs:675:9
   3: tests::test_touch::test_touch_invalid_date_format
             at ./tests/by-util/test_touch.rs:853:5
   4: tests::test_touch::test_touch_invalid_date_format::{{closure}}
             at ./tests/by-util/test_touch.rs:849:37
   5: core::ops::function::FnOnce::call_once
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/ops/function.rs:250:5
   6: core::ops::function::FnOnce::call_once
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

[sylvestre]

Thanks :)