Skip to content

pr/chgrp: fix warnings #6054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sylvestre merged 2 commits into from
Mar 10, 2024
Merged

pr/chgrp: fix warnings #6054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9054a24
pr: fix deprecation warnings & remove comment
cakebaker Mar 10, 2024
0579233
chgrp: fix clippy warning
cakebaker Mar 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions tests/by-util/test_chgrp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,8 @@ fn test_preserve_root_symlink() {
] {
let (at, mut ucmd) = at_and_ucmd!();
at.symlink_file(d, file);
let expected_error = format!(
"chgrp: it is dangerous to operate recursively on 'test_chgrp_symlink2root' (same as '/')\nchgrp: use --no-preserve-root to override this failsafe\n",
//d,
);
let expected_error =
"chgrp: it is dangerous to operate recursively on 'test_chgrp_symlink2root' (same as '/')\nchgrp: use --no-preserve-root to override this failsafe\n";
ucmd.arg("--preserve-root")
.arg("-HR")
.arg("bin")
Expand Down
5 changes: 2 additions & 3 deletions tests/by-util/test_pr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,12 @@ fn file_last_modified_time(ucmd: &UCommand, path: &str) -> String {
}

fn all_minutes(from: DateTime<Utc>, to: DateTime<Utc>) -> Vec<String> {
let to = to + Duration::minutes(1);
// const FORMAT: &str = "%b %d %H:%M %Y";
let to = to + Duration::try_minutes(1).unwrap();
let mut vec = vec![];
let mut current = from;
while current < to {
vec.push(current.format(DATE_TIME_FORMAT).to_string());
current += Duration::minutes(1);
current += Duration::try_minutes(1).unwrap();
}
vec
}
Expand Down