kill: support multiple signals for --list#6210
Merged
BenWiederhake merged 3 commits intouutils:mainfrom Apr 12, 2024
Merged
Conversation
|
GNU testsuite comparison: |
BenWiederhake
requested changes
Apr 10, 2024
Collaborator
BenWiederhake
left a comment
There was a problem hiding this comment.
Looks good, especially good catch regarding the continue-on-error behavior!
Please also write tests so that we don't regress in the future. (Eventually the argument parser will be rewritten, and it would be nice to know for sure that features like this didn't accidentally break.)
Contributor
Author
|
I have added necessary tests for multiple signals as well as to test for vertical list #6213 |
|
GNU testsuite comparison: |
BenWiederhake
approved these changes
Apr 12, 2024
Collaborator
BenWiederhake
left a comment
There was a problem hiding this comment.
Loogs good, and thank you for adding the test for vertical signals!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #6202
Changes
Multiple signal input support for --list command
Don't terminate and display error inline when signal is not recognized