remove PROJECT_NAME_FOR_VERSION_STRING#8360
Merged
cakebaker merged 1 commit intouutils:mainfrom Jul 21, 2025
Merged
Conversation
This fixes out-of-tree builds which are using --manifest-path and ignoring .cargo/config.toml because of rust-lang/cargo#2930 : ``` git clone https://github.com/uutils/coreutils.git mkdir test && cd test cargo build --manifest-path=../coreutils/Cargo.toml ``` This also fixes installation of coreutils from crates.io, which also ignores .cargo/config.toml: ``` cargo install coreutils --locked ``` Using `option_env` is not possible because `concat!` needs a string literal. I don't see a need to change the project name using an environment variable, so let's keep things simple and simply remove it to fix this bug. Fixes uutils#7992 Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
Ecordonnier
force-pushed
the
eco/fix-out-of-tree-build
branch
from
21b2c0e to
c611993
Compare
Collaborator
Author
|
The original idea of the code was to allow other projects like e.g. uutils findutils, to reuse the uucore macro |
|
GNU testsuite comparison: |
cakebaker
reviewed
Jul 21, 2025
Comment on lines
+1
to
+3
| # Note: keep in mind that this file is completely ignored in several use-cases | ||
| # like e.g. out-of-tree builds ( https://github.com/rust-lang/cargo/issues/2930 ). | ||
| # For this reason this file should be avoided as much as possible when there are alternatives. |
Contributor
|
Thanks! |
fdncred
added a commit
to nushell/nushell
that referenced
this pull request
Sep 24, 2025
This is a follow up to #15896 and #15932 and updates nushell to use the coreutils crates v0.2.2. We should try to stay on the latest coreutils version as much as possible. Coreutils has reverted the main problem we had which was the need to have a `PROJECT_NAME_FOR_VERSION_STRING` environment variable. For reference, https://github.com/uutils/coreutils/blob/5287738e9c408cf665e5a87c4df03bdc1685bb8f/docs/src/release-notes/0.2.0.md?plain=1#L528 uutils/coreutils#8360 ## Release notes summary - What our users need to know N/A ## Tasks after submitting N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes out-of-tree builds which are using --manifest-path and ignoring .cargo/config.toml because of rust-lang/cargo#2930 :
This also fixes installation of coreutils from crates.io, which also ignores .cargo/config.toml:
Using
option_envis not possible becauseconcat!needs a string literal. I don't see a need to change the project name using an environment variable, so let's keep things simple and simply remove it to fix this bug.Fixes #7992