stat: fix %N symlink to be single quote instead of double quote#8791
Merged
Conversation
Contributor
Author
|
i think i need to fix this failing test first |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging #8791 will improve performances by 3.28%Comparing Summary
Benchmarks breakdown
Footnotes
|
Contributor
|
Could you please add a test to make sure we don't regress? |
Contributor
Author
|
Sure, I will get started on it |
sylvestre
reviewed
Oct 6, 2025
|
GNU testsuite comparison: |
Contributor
|
I would like an integration test in tests/by-util/test_stat.rs |
Contributor
Author
|
Alright sure I will add it |
|
GNU testsuite comparison: |
Contributor
Author
|
@sylvestre , is there any updates on this pr ? |
Contributor
|
lgtm, thanks and sorry for the latency! |
Contributor
Author
|
thanks for your time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #8789