ci: patch codspeed v4.0.4 for gnu11 compatibility#8906
Closed
naoNao89 wants to merge 3 commits intouutils:mainfrom
Closed
ci: patch codspeed v4.0.4 for gnu11 compatibility#8906naoNao89 wants to merge 3 commits intouutils:mainfrom
naoNao89 wants to merge 3 commits intouutils:mainfrom
Conversation
naoNao89
force-pushed
the
fix/codspeed-4.0.4-gnu11-compatibility
branch
from
1689884 to
7dbd1d1
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Dynamically patches codspeed build.rs during CI to use gnu11 instead of gnu17, addressing CodSpeedHQ/codspeed-rust#139 for older GCC toolchain compatibility in cross-compilation containers. Implementation: - Clone and patch codspeed v4.0.4 with retry logic - Validate build.rs and verify patch application - Inject [patch.crates-io] configuration at runtime - Platform-aware sed handling (macOS/Linux) - Update Cargo.lock for patched dependency The patch applies only during CI runs and does not persist in source control.
Fixes cspell error for OSTYPE shell variable used in CI workflow
Move CODSPEED_TMP from system temp (/tmp) to workspace directory (.codspeed-patch) to ensure Docker containers used by cross can access the patched source. Add cleanup to remove temporary directory after use.
sylvestre
force-pushed
the
fix/codspeed-4.0.4-gnu11-compatibility
branch
from
1fb2499 to
4d310fd
Compare
|
GNU testsuite comparison: |
Contributor
|
@naoNao89 ping? |
Contributor
|
Closing this PR as codspeed v4.0.5 resolved the issue. Anyway, thanks for your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CodSpeedHQ/codspeed-rust#139 and #8858
bug: cross tool (used in our CI) ships with older GCC that doesn't support gnu17. Codspeed v4.0.4 hardcodes -std=gnu17 in its build.rs, causing builds to fail on i686-unknown-linux-gnu and x86_64-unknown-linux-gnu targets.
fix: our CI workflow now patches codspeed at runtime before building. It clones the codspeed source, changes gnu17 to gnu11 in build.rs, and tells cargo to use the patched version via a temporary cargo patch directive.
This unblocks our CI cross-compilation builds while we wait for upstream (CodSpeedHQ/codspeed-rust#139) to fix it properly. The patch is CI-only and doesn't touch our source tree.