rm: fix error reporting for -r on Linux#9011
Closed
Arcterus wants to merge 1 commit intouutils:mainfrom
Closed
Conversation
Arcterus
changed the title
-r on Linux
|
GNU testsuite comparison: |
Contributor
|
nice to see you again @Arcterus ;) |
Contributor
|
and could you please split the perl change into two commits? as it isn't related at all |
Collaborator
|
Was searching through the failing tests to see if any have pr's open for fixes, mind if I build on-top your commits in another PR and follow up on getting this implemented. |
Contributor
|
sorry, it needs to be rebased! |
Collaborator
|
I made a PR that includes your commits from this PR: #10111 Turns out we already had a test for this exact GNU test scenario but it was just not implemented correctly. |
Contributor
|
let's use #10111 |
sylvestre
pushed a commit
that referenced
this pull request
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was the cause of the
rm1.shfailure for the GNU testsuite.Effectively, the error boolean only kept track of the last file that we attempted to remove rather than the entire set of files.
I've also added
perltoflake.nix, since I'm currently usingnixon a system that doesn't have it by default.