Skip to content

fix(uucore): replace busy loop with pselect(2)#9154

Closed
Alonely0 wants to merge 0 commit intouutils:mainfrom
Alonely0:timeout
Closed

fix(uucore): replace busy loop with pselect(2)#9154
Alonely0 wants to merge 0 commit intouutils:mainfrom
Alonely0:timeout

Conversation

@Alonely0
Copy link
Contributor

@Alonely0 Alonely0 commented Nov 6, 2025

Fixes an issue in uu_timeout where there would always be 100ms latency. This PR supersedes #9123 due to platform support issues, and fixes #9099.

@Alonely0 Alonely0 force-pushed the timeout branch 5 times, most recently from 3397ee8 to 0f1851f Compare November 6, 2025 02:44
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

GNU testsuite comparison:

GNU test failed: tests/wc/wc-proc. tests/wc/wc-proc is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 6, 2025

CodSpeed Performance Report

Merging #9154 will not alter performance

Comparing Alonely0:timeout (18b80a9) with main (601564b)

Summary

✅ 71 untouched
⏩ 57 skipped1

Footnotes

  1. 57 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Alonely0 Alonely0 force-pushed the timeout branch 3 times, most recently from ab2e10b to 663752e Compare November 6, 2025 03:51
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

GNU testsuite comparison:

GNU test failed: tests/df/unreadable. tests/df/unreadable is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/head/head-write-error. tests/head/head-write-error is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/ls/infloop. tests/ls/infloop is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@Alonely0 Alonely0 force-pushed the timeout branch 2 times, most recently from dcbcb73 to 33b7d4e Compare November 6, 2025 04:40
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

GNU testsuite comparison:

GNU test failed: tests/head/head-write-error. tests/head/head-write-error is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/df/total-verify is now being skipped but was previously passing.

@Alonely0
Copy link
Contributor Author

Alonely0 commented Nov 6, 2025

Hey! Could someone with access to a macOS machine try to reproduce the spurious CI failures? I have been all morning (unsuccesfully) trying to get some useful logs or backtraces out of CI lol.

@Alonely0 Alonely0 force-pushed the timeout branch 6 times, most recently from aeb795a to feda114 Compare November 6, 2025 19:46
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

GNU testsuite comparison:

GNU test failed: tests/df/unreadable. tests/df/unreadable is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/head/head-write-error. tests/head/head-write-error is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/ls/infloop. tests/ls/infloop is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail/tail-c. tests/tail/tail-c is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

GNU testsuite comparison:

GNU test failed: tests/tail/pid. tests/tail/pid is passing on 'main'. Maybe you have to rebase?

@Alonely0 Alonely0 force-pushed the timeout branch 2 times, most recently from c49f2e7 to 18b80a9 Compare November 11, 2025 11:28
@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

timeout is slow

1 participant