Skip to content

chmod:fix file descriptor limits issue#9595

Open
mattsu2020 wants to merge 2 commits intouutils:mainfrom
mattsu2020:chmod_FD_fix
Open

chmod:fix file descriptor limits issue#9595
mattsu2020 wants to merge 2 commits intouutils:mainfrom
mattsu2020:chmod_FD_fix

Conversation

@mattsu2020
Copy link
Contributor

@mattsu2020 mattsu2020 commented Dec 7, 2025

As mentioned in the comment below, it hits the file descriptor limit.

#9554 (comment)

Make adjustments to reduce the use of FD.

@github-actions
Copy link

github-actions bot commented Dec 7, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Dec 25, 2025

GNU testsuite comparison:

GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?

@uutils uutils deleted a comment from github-actions bot Dec 26, 2025
@uutils uutils deleted a comment from github-actions bot Dec 26, 2025
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

GNU testsuite comparison:

GNU test failed: tests/tty/tty-eof. tests/tty/tty-eof is passing on 'main'. Maybe you have to rebase?

@github-actions
Copy link

github-actions bot commented Jan 10, 2026

GNU testsuite comparison:

Congrats! The gnu test tests/stty/bad-speed is now passing!

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

sylvestre
sylvestre reviewed Jan 13, 2026
View reviewed changes
src/uu/chmod/src/chmod.rs Outdated

let entries = dir_fd.read_dir()?;
// Depth-first traversal without recursive calls to avoid stacking FDs.
let mut stack: Vec<(DirFd, PathBuf)> = vec![(dir_fd, dir_path.to_path_buf())];
Copy link
Contributor

@sylvestre sylvestre Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you look at the impact on the memory ?

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 288 untouched benchmarks
⏩ 38 skipped benchmarks1

Comparing mattsu2020:chmod_FD_fix (1b31f0f) with main (289d701)

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link

github-actions bot commented Jan 15, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Jan 15, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Jan 19, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Feb 14, 2026

GNU testsuite comparison:

GNU test failed: tests/factor/t10. tests/factor/t10 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/factor/t33. tests/factor/t33 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/factor/t34. tests/factor/t34 is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/tail/pipe-f is now being skipped but was previously passing.
Congrats! The gnu test tests/cut/cut-huge-range is now passing!
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!

@github-actions
Copy link

github-actions bot commented Feb 14, 2026

GNU testsuite comparison:

GNU test failed: tests/factor/t10. tests/factor/t10 is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/pr/bounded-memory is no longer failing!
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Congrats! The gnu test tests/cut/cut-huge-range is now passing!
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!

@github-actions
Copy link

github-actions bot commented Feb 18, 2026

GNU testsuite comparison:

GNU test failed: tests/date/date-locale-hour. tests/date/date-locale-hour is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/rm/isatty. tests/rm/isatty is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/cut/bounded-memory is no longer failing!
Note: The gnu test tests/unexpand/bounded-memory is now being skipped but was previously passing.

mattsu2020 added a commit to mattsu2020/coreutils that referenced this pull request Feb 18, 2026
@mattsu2020
refactor(chmod): scope PR to FD traversal fix
555d9c2 
- drop benchmark and CI additions not required for PR uutils#9595

- drop unrelated chown/perms traversal changes

- fix safe_traversal tests by passing SymlinkBehavior to DirFd::open
@mattsu2020
perf(chmod): avoid fd stacking during recursive traversal
3c73e70 
- switch safe recursive chmod traversal to iterative DFS

- add DirFd::open_subdir_chain helper for bounded descriptor usage

- add unit tests for open_subdir_chain
@mattsu2020
test(chmod): add fd-limit regression coverage
1b31f0f 
- add deep-tree and wide-tree recursive chmod tests under NOFILE=64
@github-actions
Copy link

github-actions bot commented Feb 18, 2026

GNU testsuite comparison:

GNU test failed: tests/date/date-locale-hour. tests/date/date-locale-hour is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cut/bounded-memory is no longer failing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre sylvestre left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattsu2020 @sylvestre