nl: preserve raw bytes in output instead of using from_utf8_lossy#9673
Merged
cakebaker merged 1 commit intouutils:mainfrom Dec 16, 2025
Merged
nl: preserve raw bytes in output instead of using from_utf8_lossy#9673cakebaker merged 1 commit intouutils:mainfrom
cakebaker merged 1 commit intouutils:mainfrom
Conversation
CodSpeed Performance ReportMerging #9673 will improve performances by 75.86%Comparing Summary
Benchmarks breakdown
Footnotes
|
Collaborator
Author
|
Nice, didn't realize this was also the bottleneck in performance |
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug sent me caused me a bunch of difficulty while working on the locale GNU integration tests, since non utf-8 values were being piped into nl in the GNU integration tests and then coming out as UTF-8 breaking the tests. I am curious to see if this was the root cause for some more integration tests failing in the CI.
Its a bit rough to see that there were integration tests specifically made for this scenario but the tests were implemented with the same "to_string_lossy" which made the tests actually check nothing. Ideally we should add the "matches_gnu()" to all of these integration tests: #9660 so that we can detect these issues preemptively.