ptx: implement -S/--sentence-regexp#9682
Merged
sylvestre merged 6 commits intouutils:mainfrom Dec 28, 2025
Merged
Conversation
ChrisDryden
reviewed
Dec 17, 2025
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
sylvestre
reviewed
Dec 27, 2025
sylvestre
reviewed
Dec 27, 2025
CrazyRoka
force-pushed
the
ptx-implement-sentence-regexp
branch
from
e0a5cd3 to
6009e8e
Compare
|
GNU testsuite comparison: |
CrazyRoka
force-pushed
the
ptx-implement-sentence-regexp
branch
from
6009e8e to
b5e643b
Compare
sylvestre
reviewed
Dec 27, 2025
src/uu/ptx/src/ptx.rs
Outdated
Comment on lines
+307
to
+317
| let lines = if let Some(re) = &sentence_splitter { | ||
| let mut buffer = String::new(); | ||
| reader.read_to_string(&mut buffer)?; | ||
|
|
||
| re.split(&buffer) | ||
| .map(|s| s.replace('\n', " ")) // ptx behavior: newlines become spaces inside sentences | ||
| .filter(|s| !s.is_empty()) // remove empty sentences | ||
| .collect() | ||
| } else { | ||
| reader.lines().collect::<std::io::Result<Vec<String>>>()? | ||
| }; |
Contributor
There was a problem hiding this comment.
maybe move that into a function
|
GNU testsuite comparison: |
CrazyRoka
force-pushed
the
ptx-implement-sentence-regexp
branch
from
81cc64d to
4ef57f5
Compare
|
GNU testsuite comparison: |
sylvestre
added a commit
to sylvestre/coreutils
that referenced
this pull request
Dec 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
-S / --sentence-regexpflag forptx, bringing it closer to full GNU compatibility.Previously,
ptxonly supported splitting input by lines. This change allows users to define a custom regular expression to split the input into sentences, as specified in the GNU documentation.Tests
GNU Compatibility: This fixes the previously failing
tests/ptx/ptx.pltest caseS-infloop.Unit Tests: Added new Rust unit tests in
tests/by-util/test_ptx.rs.