Skip to content

Fix printenv non-UTF8#9728

Merged
sylvestre merged 2 commits intouutils:mainfrom
RenjiSann:fix-printenv-utf8
Dec 22, 2025
Merged

Fix printenv non-UTF8#9728
sylvestre merged 2 commits intouutils:mainfrom
RenjiSann:fix-printenv-utf8

Conversation

@RenjiSann
Copy link
Collaborator

@RenjiSann RenjiSann commented Dec 19, 2025 •
edited by cakebaker
Loading

Fixes #9701

@RenjiSann RenjiSann requested a review from sylvestre December 19, 2025 22:50
@sylvestre
Copy link
Contributor

sylvestre commented Dec 19, 2025

this is the third pr for the same issue now :)
#9726
#9702

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@ChrisDryden
Copy link
Collaborator

ChrisDryden commented Dec 19, 2025

#9726 is env and #9702 is printenv

@ChrisDryden
Copy link
Collaborator

ChrisDryden commented Dec 19, 2025

Ideally you can take @RenjiSann 's implementation and @sylvestre 's tests, get the best of both PR's

@RenjiSann
Copy link
Collaborator Author

RenjiSann commented Dec 21, 2025

Replaced my test with @sylvestre's

@github-actions
Copy link

github-actions bot commented Dec 21, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

@sylvestre
Copy link
Contributor

sylvestre commented Dec 21, 2025

many jobs are failing :)

@github-actions
Copy link

github-actions bot commented Dec 21, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/dd/no-allocate was skipped on 'main' but is now failing.
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

@sylvestre sylvestre merged commit 0bfbbc0 into uutils:main Dec 22, 2025
186 of 188 checks passed
@RenjiSann RenjiSann deleted the fix-printenv-utf8 branch December 22, 2025 13:30
CrazyRoka pushed a commit to CrazyRoka/coreutils that referenced this pull request Dec 28, 2025
@RenjiSann @CrazyRoka
Fix printenv non-UTF8 (uutils#9728)
3ae5b7a 
* printenv: Handle invalid UTF-8 encoding in variables

* test(printenv): Add test for non-UTF8 content in variable
@moonfruit moonfruit mentioned this pull request Feb 3, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre Awaiting requested review from sylvestre

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

printenv skips environment variables with invalid UTF-8

3 participants

@RenjiSann @sylvestre @ChrisDryden