dd: fix nocache flag handling at EOF#9818
Merged
sylvestre merged 3 commits intouutils:mainfrom Jan 5, 2026
Merged
Conversation
|
GNU testsuite comparison: |
Contributor
|
would it be possible to add a test in rust too? thanks |
ChrisDryden
force-pushed
the
fix-dd-nocache-eof
branch
from
6aa916d to
ae0b15b
Compare
Collaborator
Author
|
Added some tests based off of what the GNU tests are doing |
|
GNU testsuite comparison: |
sylvestre
approved these changes
Dec 30, 2025
Contributor
sylvestre
left a comment
sylvestre
left a comment
There was a problem hiding this comment.
lgtm, waiting for the ci to finish
Collaborator
Author
|
That fail is from the tty-eof test, is being flaky |
Collaborator
Author
|
@sylvestre all good for this one? |
aaron-ang
pushed a commit
to aaron-ang/coreutils
that referenced
this pull request
Jan 6, 2026
* dd: fix nocache flag handling at EOF * Add tests for nocache EOF handling --------- Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
sgmarz
pushed a commit
to sgmarz/coreutils
that referenced
this pull request
Jan 7, 2026
* dd: fix nocache flag handling at EOF * Add tests for nocache EOF handling --------- Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theres a GNU test that validates that the value 0 is used in the strace when clearing the cache in the trace for posix_fadvise. This is because 0 as an input for the length of the file means until the end of the file. This simplifies the code and removes the need for the helper functions.
What was also missing was a check to clear the caches if the read buffer is empty for when it reaches the EOF