sort : gnu core utils test (sort-merge-fdlimit.sh) by mattsu2020 · Pull Request #9849 · uutils/coreutils

mattsu2020 · 2025-12-25T23:32:56Z

Modifications were made to pass the GNU coreutils tests.

github-actions · 2025-12-25T23:55:53Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

src/uu/sort/Cargo.toml

src/uu/sort/src/sort.rs

sylvestre · 2025-12-26T00:03:27Z

some jobs are failing and please add tests

codspeed-hq · 2025-12-26T00:16:55Z

Merging this PR will improve performance by ×2.1

⚡ 33 improved benchmarks
✅ 249 untouched benchmarks
⏩ 38 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	Simulation	`sort_case_sensitive[500000]`	166.4 ms	151.9 ms	+9.61%
⚡	Simulation	`sort_ascii_only[500000]`	344.4 ms	329.7 ms	+4.45%
⚡	Simulation	`sort_ascii_utf8_locale`	20.4 ms	18.1 ms	+12.51%
⚡	Simulation	`sort_ascii_c_locale`	20.5 ms	18.4 ms	+11.59%
⚡	Simulation	`sort_numeric_utf8_locale`	22.5 ms	20.1 ms	+11.72%
⚡	Simulation	`sort_case_insensitive[500000]`	267.3 ms	255.3 ms	+4.68%
⚡	Simulation	`sort_accented_data[500000]`	353.2 ms	338.5 ms	+4.34%
⚡	Simulation	`sort_mixed_data[500000]`	319.1 ms	304.3 ms	+4.87%
⚡	Simulation	`sort_long_line[160000]`	1.7 ms	1.4 ms	+18.02%
⚡	Simulation	`sort_reverse_locale[500000]`	352.3 ms	337.4 ms	+4.41%
⚡	Simulation	`sort_unique_locale[500000]`	485.3 ms	469.9 ms	+3.26%
⚡	Memory	`sort_ascii_utf8_locale`	6.2 MB	5.6 MB	+10.99%
⚡	Memory	`sort_reverse_locale[500000]`	27.5 MB	21.6 MB	+27.62%
⚡	Memory	`sort_unique_utf8_locale`	4.6 MB	3.8 MB	+23.44%
⚡	Memory	`sort_mixed_c_locale`	3 MB	2.6 MB	+13.78%
⚡	Memory	`sort_accented_data[500000]`	28.3 MB	25.5 MB	+11.04%
⚡	Memory	`sort_numeric_utf8_locale`	8.8 MB	4.2 MB	×2.1
⚡	Memory	`sort_long_line[160000]`	981.4 KB	738.3 KB	+32.93%
⚡	Memory	`sort_dictionary_order[500000]`	42 MB	29.7 MB	+41.6%
⚡	Memory	`sort_mixed_utf8_locale`	3.5 MB	2.6 MB	+34.07%
...	...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

_{Comparing mattsu2020:sort/sort-merge-fdlimit.sh (0ec5f0d) with main (2a044db)}

38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2025-12-26T05:39:36Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

github-actions · 2025-12-29T10:19:40Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

github-actions · 2025-12-29T11:05:40Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

sylvestre · 2025-12-29T15:02:43Z

please have a look to the perf regression, 9% is a bit too much

github-actions · 2025-12-30T13:10:06Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

github-actions · 2026-01-05T11:58:43Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

github-actions · 2026-01-06T04:16:55Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

github-actions · 2026-01-06T04:45:05Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

github-actions · 2026-01-06T04:54:12Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

github-actions · 2026-01-06T05:50:46Z

GNU testsuite comparison:

GNU test failed: tests/shuf/shuf-reservoir. tests/shuf/shuf-reservoir is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!
Congrats! The gnu test tests/tail/follow-name is no longer failing!

github-actions · 2026-01-06T09:20:22Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

github-actions · 2026-01-06T10:21:06Z

GNU testsuite comparison:

GNU test failed: tests/shuf/shuf-reservoir. tests/shuf/shuf-reservoir is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!
Congrats! The gnu test tests/tty/tty-eof is no longer failing!

github-actions · 2026-01-06T10:47:51Z

GNU testsuite comparison:

Congrats! The gnu test tests/shuf/shuf-reservoir is no longer failing!
Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!
Congrats! The gnu test tests/sort/sort-stale-thread-mem is no longer failing!

github-actions · 2026-01-06T11:25:13Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/shuf/shuf-reservoir is no longer failing!
Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!
Congrats! The gnu test tests/sort/sort-stale-thread-mem is no longer failing!

github-actions · 2026-01-14T09:10:17Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

- Use libc::fcntl for invalid fd probing to avoid errors - Make ctrlc/signal handling conditional on Redox - Skip fd soft-limit checks on unsupported Unix variants - Allow FreeBSD-specific clippy allowances where needed

- Reuse a per-chunk token buffer to reduce allocations - Track a line_count_hint and reserve capacities efficiently - Compute exact line counts for small chunks or unknown hints - Skip tokenization/data extraction when settings do not need it

- Ensure /usr/local/etc/pkg/repos exists before writing config - Write FreeBSD pkg repo configuration in both jobs - Force a repo update by removing stale package db

- Bump multiple crates in Cargo.lock for bugfixes and security updates - Refresh deny.toml exceptions as needed

github-actions · 2026-01-14T10:47:04Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

github-actions · 2026-01-15T12:34:18Z

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

Updated various Rust crates to latest versions, including cc (1.2.51 -> 1.2.52), chrono (0.4.42 -> 0.4.43), flate2 (1.1.5 -> 1.1.8), getrandom (0.2.16 -> 0.2.17), indexmap (2.12.1 -> 2.13.0), and others. Removed unused 'arbitrary' and 'derive_arbitrary' packages. Adjusted dependencies in flate2 to use 'zlib-rs' instead of 'libz-rs-sys'. This ensures compatibility and incorporates recent bug fixes and improvements.

github-actions · 2026-01-15T13:26:43Z

GNU testsuite comparison:

GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

github-actions · 2026-01-17T12:22:36Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

…setup Remove unnecessary pkg repository configuration and update steps in FreeBSD CI jobs, assuming default repos suffice, to streamline and speed up workflow execution.

…ecific allowances and cfg conditions in inode and nlink methods FreeBSD's st_ino and st_nlink are now handled consistently with other 64-bit platforms, eliminating unnecessary type conversions and clippy allowances for better code clarity and maintenance.

sylvestre · 2026-01-18T09:39:41Z

@mattsu2020 is it ready for review? thanks

sylvestre · 2026-01-18T21:45:33Z

impressive perf wins

sylvestre reviewed Dec 26, 2025

View reviewed changes

src/uu/sort/Cargo.toml Outdated Show resolved Hide resolved

sylvestre reviewed Dec 26, 2025

View reviewed changes

src/uu/sort/src/sort.rs Outdated Show resolved Hide resolved

sylvestre reviewed Dec 26, 2025

View reviewed changes

src/uu/sort/src/sort.rs Outdated Show resolved Hide resolved

ChrisDryden mentioned this pull request Dec 26, 2025

GNU coreutils 9.9: Detailed Test report 12/19 #9729

Closed

mattsu2020 force-pushed the sort/sort-merge-fdlimit.sh branch from a7a24fa to cafb3ca Compare January 5, 2026 10:55

mattsu2020 marked this pull request as draft January 5, 2026 23:27

mattsu2020 force-pushed the sort/sort-merge-fdlimit.sh branch from d4c4389 to 1a1eabd Compare January 6, 2026 04:35

mattsu2020 marked this pull request as ready for review January 6, 2026 11:44

feat(sort): add --random-source option

3b86047

mattsu2020 force-pushed the sort/sort-merge-fdlimit.sh branch from 9e9b311 to 9853dd5 Compare January 14, 2026 08:40

mattsu2020 added 2 commits January 14, 2026 19:18

compat(sort): improve fd handling on nonstandard platforms

f09e8a8

- Use libc::fcntl for invalid fd probing to avoid errors - Make ctrlc/signal handling conditional on Redox - Skip fd soft-limit checks on unsupported Unix variants - Allow FreeBSD-specific clippy allowances where needed

mattsu2020 added 2 commits January 14, 2026 19:18

ci: fix FreeBSD pkg repo setup

ea77daa

- Ensure /usr/local/etc/pkg/repos exists before writing config - Write FreeBSD pkg repo configuration in both jobs - Force a repo update by removing stale package db

chore(deps): update Rust dependencies

7c5749f

- Bump multiple crates in Cargo.lock for bugfixes and security updates - Refresh deny.toml exceptions as needed

mattsu2020 force-pushed the sort/sort-merge-fdlimit.sh branch from 9853dd5 to 7c5749f Compare January 14, 2026 10:22

Merge branch 'main' into sort/sort-merge-fdlimit.sh

67b6c38

mattsu2020 requested a review from sylvestre January 15, 2026 23:48

mattsu2020 marked this pull request as draft January 17, 2026 12:06

Merge branch 'main' into sort/sort-merge-fdlimit.sh

b30b8f0

mattsu2020 added 2 commits January 17, 2026 21:56

refactor(ci): simplify FreeBSD CI prepare steps by removing pkg repo …

47b356c

…setup Remove unnecessary pkg repository configuration and update steps in FreeBSD CI jobs, assuming default repos suffice, to streamline and speed up workflow execution.

mattsu2020 marked this pull request as ready for review January 18, 2026 14:27

sylvestre merged commit 87c332c into uutils:main Jan 18, 2026
157 of 158 checks passed

mattsu2020 deleted the sort/sort-merge-fdlimit.sh branch January 18, 2026 22:45

mattsu2020 added a commit to mattsu2020/coreutils that referenced this pull request Jan 23, 2026

sort : gnu core utils test (sort-merge-fdlimit.sh) (uutils#9849)

d939804

moonfruit mentioned this pull request Feb 3, 2026

uutils-selected 0.6.0 moonfruit/homebrew-tap#453

Closed

Uh oh!

Conversation

mattsu2020 commented Dec 25, 2025

Uh oh!

github-actions bot commented Dec 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sylvestre commented Dec 26, 2025

Uh oh!

codspeed-hq bot commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by ×2.1

Performance Changes

Footnotes

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

sylvestre commented Dec 29, 2025

Uh oh!

github-actions bot commented Dec 30, 2025

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

github-actions bot commented Jan 17, 2026

Uh oh!

sylvestre commented Jan 18, 2026

Uh oh!

sylvestre commented Jan 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codspeed-hq bot commented Dec 26, 2025 •

edited

Loading