feat(sort): add warning messages for obsolescent keys and options by mattsu2020 · Pull Request #9900 · uutils/coreutils

mattsu2020 · 2025-12-29T02:57:50Z

Added localized warning messages in en-US.ftl for various sort command issues, including obsolescent key formats, ignored options, and locale-related warnings. Implemented LegacyKeyWarning struct and GlobalOptionFlags in sort.rs to detect deprecated key syntax (e.g., +field -field) and suggest modern -k replacements, improving user guidance and compatibility.

fix
sort/sort-debug-warn.sh

Added localized warning messages in en-US.ftl for various sort command issues, including obsolescent key formats, ignored options, and locale-related warnings. Implemented LegacyKeyWarning struct and GlobalOptionFlags in sort.rs to detect deprecated key syntax (e.g., +field -field) and suggest modern -k replacements, improving user guidance and compatibility.

Removes the unused `stable` and `unique` boolean fields from the GlobalOptionFlags struct and their initialization in the impl block, simplifying the code by eliminating redundant options.

github-actions · 2025-12-29T03:19:46Z

GNU testsuite comparison:

Note: The gnu test tests/id/smack was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-no-root was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-root was skipped on 'main' but is now failing.

Previously, sort mode flags were mutually exclusive, preventing users from specifying more than one mode. This change removes the conflicts to enable combining sort options for more flexible sorting behavior.

codspeed-hq · 2025-12-29T05:00:45Z

CodSpeed Performance Report

Merging #9900 will not alter performance

_{Comparing mattsu2020:sort/sort-debug-warn.sh (ea1bfcd) with main (1e11921)}

Summary

✅ 136 untouched
⏩ 24 skipped¹

24 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2025-12-29T05:03:12Z

GNU testsuite comparison:

GNU test failed: tests/tty/tty-eof. tests/tty/tty-eof is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/sort/sort-debug-warn is no longer failing!

github-actions · 2025-12-29T05:20:56Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-debug-warn is no longer failing!

sylvestre · 2025-12-29T14:25:29Z

thanks. It needs some tests

sylvestre · 2025-12-29T14:29:20Z

also, please have a look on the perf regression - -4.52% is quite high

github-actions · 2025-12-29T15:53:06Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-debug-warn is no longer failing!

- Update LegacyKeyWarning struct to include arg_index and make key_index optional - Modify preprocess_legacy_args to set arg_index instead of key_index during parsing - Add index_legacy_warnings function to compute key_index after arg processing - Adjust emit_debug_warnings to match updated key_index type - This ensures accurate indexing for legacy key warnings in sort utility

github-actions · 2025-12-31T06:48:09Z

GNU testsuite comparison:

GNU test failed: tests/tty/tty-eof. tests/tty/tty-eof is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/sort/sort-debug-warn is no longer failing!

- Introduce `starts_with_plus` function to check for arguments starting with '+' in a platform-specific manner - Modify `parse_sort_arguments` to detect and process legacy sort keys, enabling proper handling of deprecated options with warnings - This ensures backward compatibility for users relying on old sort syntax while guiding migration to modern flags

github-actions · 2025-12-31T07:13:52Z

GNU testsuite comparison:

GNU test failed: tests/tty/tty-eof. tests/tty/tty-eof is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/sort/sort-debug-warn is no longer failing!

github-actions · 2025-12-31T09:01:06Z

GNU testsuite comparison:

GNU test failed: tests/shuf/shuf-reservoir. tests/shuf/shuf-reservoir is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/sort/sort-debug-warn is no longer failing!

github-actions · 2026-01-01T07:01:57Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-debug-warn is no longer failing!

Remove intermediate vector creation in preprocess_legacy_args and streamline the handling of legacy '+' prefixed arguments to improve efficiency and readability without altering functionality. Additionally, refactor uumain to directly index legacy warnings when present.

github-actions · 2026-01-01T07:52:26Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-debug-warn is no longer failing!
Congrats! The gnu test tests/tail/follow-name is no longer failing!

…g args Move output file creation and argument setup outside benchmark loops in sort_locale_utf8_bench.rs to avoid measuring initialization time in each iteration, ensuring accurate performance measurements for sorting operations.

github-actions · 2026-01-01T08:50:39Z

GNU testsuite comparison:

Congrats! The gnu test tests/shuf/shuf-reservoir is no longer failing!
Congrats! The gnu test tests/sort/sort-debug-warn is no longer failing!
Congrats! The gnu test tests/sort/sort-stale-thread-mem is no longer failing!

github-actions · 2026-01-01T09:49:28Z

GNU testsuite comparison:

Congrats! The gnu test tests/shuf/shuf-reservoir is no longer failing!
Congrats! The gnu test tests/sort/sort-debug-warn is no longer failing!
Congrats! The gnu test tests/sort/sort-stale-thread-mem is no longer failing!

…tils#9900) * feat(sort): add warning messages for obsolescent keys and options Added localized warning messages in en-US.ftl for various sort command issues, including obsolescent key formats, ignored options, and locale-related warnings. Implemented LegacyKeyWarning struct and GlobalOptionFlags in sort.rs to detect deprecated key syntax (e.g., +field -field) and suggest modern -k replacements, improving user guidance and compatibility. * refactor(sort): remove stable and unique flags from GlobalOptionFlags Removes the unused `stable` and `unique` boolean fields from the GlobalOptionFlags struct and their initialization in the impl block, simplifying the code by eliminating redundant options. * feat(sort): allow multiple sort modes by removing mutual conflicts Previously, sort mode flags were mutually exclusive, preventing users from specifying more than one mode. This change removes the conflicts to enable combining sort options for more flexible sorting behavior. * refactor(sort): separate arg_index and key_index in legacy key warnings - Update LegacyKeyWarning struct to include arg_index and make key_index optional - Modify preprocess_legacy_args to set arg_index instead of key_index during parsing - Add index_legacy_warnings function to compute key_index after arg processing - Adjust emit_debug_warnings to match updated key_index type - This ensures accurate indexing for legacy key warnings in sort utility * feat(sort): add legacy sort key detection for '+' prefixed arguments - Introduce `starts_with_plus` function to check for arguments starting with '+' in a platform-specific manner - Modify `parse_sort_arguments` to detect and process legacy sort keys, enabling proper handling of deprecated options with warnings - This ensures backward compatibility for users relying on old sort syntax while guiding migration to modern flags * refactor(sort): simplify legacy args preprocessing Remove intermediate vector creation in preprocess_legacy_args and streamline the handling of legacy '+' prefixed arguments to improve efficiency and readability without altering functionality. Additionally, refactor uumain to directly index legacy warnings when present. * refactor(sort/benches): optimize locale UTF8 benchmarks by predefining args Move output file creation and argument setup outside benchmark loops in sort_locale_utf8_bench.rs to avoid measuring initialization time in each iteration, ensuring accurate performance measurements for sorting operations. --------- Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>

mattsu2020 added 2 commits December 29, 2025 10:00

refactor(sort): remove stable and unique flags from GlobalOptionFlags

8c71a20

Removes the unused `stable` and `unique` boolean fields from the GlobalOptionFlags struct and their initialization in the impl block, simplifying the code by eliminating redundant options.

feat(sort): allow multiple sort modes by removing mutual conflicts

6d22316

Previously, sort mode flags were mutually exclusive, preventing users from specifying more than one mode. This change removes the conflicts to enable combining sort options for more flexible sorting behavior.

Merge branch 'main' into sort/sort-debug-warn.sh

20fee92

Merge branch 'main' into sort/sort-debug-warn.sh

76050a5

Merge branch 'main' into sort/sort-debug-warn.sh

429edf7

Merge branch 'main' into sort/sort-debug-warn.sh

82c53a4

Merge branch 'main' into sort/sort-debug-warn.sh

ea1bfcd

ChrisDryden mentioned this pull request Jan 6, 2026

GNU coreutils 9.9: Detailed Test report 12/19 #9729

Closed

sylvestre merged commit 4ba5db0 into uutils:main Jan 13, 2026
129 of 130 checks passed

mattsu2020 deleted the sort/sort-debug-warn.sh branch January 13, 2026 23:07

moonfruit mentioned this pull request Feb 3, 2026

uutils-selected 0.6.0 moonfruit/homebrew-tap#453

Closed

Uh oh!

Conversation

mattsu2020 commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

codspeed-hq bot commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #9900 will not alter performance

Summary

Footnotes

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

sylvestre commented Dec 29, 2025

Uh oh!

sylvestre commented Dec 29, 2025

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

github-actions bot commented Dec 31, 2025

Uh oh!

github-actions bot commented Dec 31, 2025

Uh oh!

github-actions bot commented Dec 31, 2025

Uh oh!

github-actions bot commented Jan 1, 2026

Uh oh!

github-actions bot commented Jan 1, 2026

Uh oh!

github-actions bot commented Jan 1, 2026

Uh oh!

github-actions bot commented Jan 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mattsu2020 commented Dec 29, 2025 •

edited

Loading

codspeed-hq bot commented Dec 29, 2025 •

edited

Loading