Skip to content

Implement : Chained Type matcher arguments#527

Merged
sylvestre merged 28 commits intouutils:mainfrom
Crypto-Darth:type_matcher
Apr 24, 2025
Merged

Implement : Chained Type matcher arguments#527
sylvestre merged 28 commits intouutils:mainfrom
Crypto-Darth:type_matcher

Conversation

@Crypto-Darth
Copy link
Copy Markdown
Contributor

Refer - https://www.gnu.org/software/findutils/manual/html_node/find_html/Type.html

As a GNU extension, multiple file types can be provided as a combined list separated by comma ‘,’. For example, ‘-type f,d,l’ is logically interpreted as ‘( -type f -o -type d -o -type l )’.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 5, 2025

Codecov Report

Attention: Patch coverage is 96.47059% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.70%. Comparing base (cacb1c1) to head (8ffc30d).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/find/matchers/type_matcher.rs 96.47% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #527      +/-   ##
==========================================
+ Coverage   87.49%   87.70%   +0.20%     
==========================================
  Files          31       31              
  Lines        6815     6887      +72     
  Branches      321      324       +3     
==========================================
+ Hits         5963     6040      +77     
+ Misses        621      616       -5     
  Partials      231      231              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/find/matchers/type_matcher.rs Outdated
Comment thread src/find/matchers/type_matcher.rs Outdated
Comment thread src/find/matchers/type_matcher.rs Outdated
@Crypto-Darth Crypto-Darth requested a review from sylvestre April 6, 2025 18:58
@Crypto-Darth
Copy link
Copy Markdown
Contributor Author

Crypto-Darth commented Apr 7, 2025

image

New testcase passing :)

Not sure why CI isn't sending message regarding same.

image
for comparison - above image is from head commit of main repo

Comment thread src/find/matchers/type_matcher.rs Outdated
@sylvestre
Copy link
Copy Markdown
Contributor

Could you please add tests at the binary level?
Not only at the function level :)

Merci

Comment thread src/find/matchers/type_matcher.rs Outdated
@Crypto-Darth
Copy link
Copy Markdown
Contributor Author

Could you please add tests at the binary level? Not only at the function level :)

Merci

@sylvestre Done :)

Comment thread src/find/matchers/type_matcher.rs Outdated
Comment thread src/find/matchers/type_matcher.rs Outdated
@Crypto-Darth Crypto-Darth requested a review from tavianator April 9, 2025 09:10
Comment thread src/find/matchers/type_matcher.rs Outdated
Comment thread src/find/matchers/type_matcher.rs Outdated
Comment thread src/find/matchers/type_matcher.rs
Comment thread src/find/matchers/type_matcher.rs Outdated
@Crypto-Darth Crypto-Darth requested a review from tavianator April 9, 2025 18:02
@Crypto-Darth
Copy link
Copy Markdown
Contributor Author

@tavianator let me know if it's good to go :)

@Crypto-Darth
Copy link
Copy Markdown
Contributor Author

@tavianator Please confirm if good to go.

Comment thread src/find/matchers/type_matcher.rs Outdated
@Crypto-Darth Crypto-Darth requested a review from tavianator April 12, 2025 18:41
@sylvestre sylvestre merged commit a571de6 into uutils:main Apr 24, 2025
20 checks passed
@Crypto-Darth
Copy link
Copy Markdown
Contributor Author

Thank you :)

@sylvestre
Copy link
Copy Markdown
Contributor

thank you and sorry for the latency :(

@Crypto-Darth
Copy link
Copy Markdown
Contributor Author

thank you and sorry for the latency :(

No worries all good I understand :)

@Crypto-Darth Crypto-Darth deleted the type_matcher branch April 24, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants