Overflow surplus days when adding months to a date#100
Merged
sylvestre merged 1 commit intouutils:mainfrom Jan 18, 2025
Merged
Conversation
Change the behavior of `parse_relative_time_at_date()` so that adding months to a given date causes surplus days to overflow to the next month. For example, adding 1 month to 1996-03-31 would be 1996-04-31, but April only has 30 days, so the surplus day rolls over to the next month, resulting in 1996-05-01. Closes uutils#98
sylvestre
force-pushed
the
add-months-overflow-surplus-days
branch
from
2fcc2c0 to
90d22a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the behavior of
parse_relative_time_at_date()so that adding months to a given date causes surplus days to overflow to the next month. For example, adding 1 month to 1996-03-31 would be 1996-04-31, but April only has 30 days, so the surplus day rolls over to the next month, resulting in 1996-05-01.Closes #98