fix relative date time handling

[yuankunzhang]

Closes #151.

[drinkcat]

Yeah, as you noted in your TODO, this is not too pretty ,-)

I wonder, can you do multiple passes over the vector? And remember whether date/time was set? (and recover the missing pieces from at as needed)

It doesn't seem like order matters for the Relative times, e.g.

date "+1 hour 2023-03-03"
date "2023-03-03 +1 hour"

both output

Fri Mar  3 01:00:00 AM CET 2023

I'm not too sure about this codebase, but maybe something like this:

• Date, DateTime, Time, Year?
• Then recover date/time from at as required?
• Then Weekday?
• Then Relative?

You could use Vec's filter to make sure that we actually go through all items.

(btw, can you cherry-pick just 6ebdf73 for this PR? I don't think this needs to stack on top of the other PR -- but IMHO that other PR could go in first...)

[yuankunzhang]

Okay I've cherry picked only this one commit in the PR.

As for the date time assembling, I've have some ideas how to improve. Will follow up on it.

[drinkcat]

Okay I've cherry picked only this one commit in the PR.

Cool thanks.

As for the date time assembling, I've have some ideas how to improve. Will follow up on it.

Do you mean follow-up as a separate PR or here? I'll let maintainers decide, but since we'd need a new release of parse_datetime I'm not sure if it's worth it to submit the current version (as a temporary but working version), make a release, then do some cleanup of this, or if we want to do the cleanup before making a new release.

[yuankunzhang]

I will do it in a separate PR.

[sylvestre]

it has a conflict, sorry

[yuankunzhang]

it has a conflict, sorry

Addressed, thanks.

[yuankunzhang]

Rebased on top of #155 .

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (c05b821) to head (9b67307).
Report is 4 commits behind head on main.

Additional details and impacted files

@@     Coverage Diff     @@
##   main   #152   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.