Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4 +/- ##
==========================================
+ Coverage 71.47% 72.49% +1.01%
==========================================
Files 2 2
Lines 312 309 -3
Branches 75 73 -2
==========================================
+ Hits 223 224 +1
+ Misses 39 35 -4
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
|
cakebaker
approved these changes
May 12, 2023
cakebaker
added a commit
that referenced
this pull request
Aug 16, 2025
(jiff series #4) refactor: optimize offset type sizes and add conversion from `Offset` to `jifff::tz::Offset`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cakebaker as you suggested, it is indeed much better this way :)