Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
==========================================
+ Coverage 18.77% 18.93% +0.16%
==========================================
Files 66 66
Lines 9752 9773 +21
Branches 516 518 +2
==========================================
+ Hits 1831 1851 +20
- Misses 7921 7922 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Franklin-Qi
force-pushed
the
fix-bug#635-optimize-length-detection
branch
3 times, most recently
from
2f41da0 to
961f167
Compare
Collaborator
|
could you please add some unittest to test your modification and make sure no regression if possible? |
Franklin-Qi
force-pushed
the
fix-bug#635-optimize-length-detection
branch
2 times, most recently
from
0d7b008 to
f0c7301
Compare
When calculating the length, the ^$ character needs to be removed if the -x parameter is present. Closes: uutils#635
Franklin-Qi
force-pushed
the
fix-bug#635-optimize-length-detection
branch
from
f0c7301 to
fb69db0
Compare
Contributor
Author
@Krysztal112233 Thank you for your review; I have added test cases in this area. |
sylvestre
reviewed
Mar 14, 2026
|
|
||
| // spawn a flock process that locks the file | ||
| let mut flock_process = Command::new("flock") | ||
| .arg("--fcntl") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calculating the length, the
^$character needs to be removed if the-xparameter is present.Closes: #635