This repository was archived by the owner on Feb 11, 2026. It is now read-only.
split 'compile_error' toy into many test cases, demonstrate new issues#134
Merged
tertsdiepraam merged 1 commit intouutils:mainfrom Apr 18, 2025
Merged
Conversation
Contributor
Author
6fdf52b to
6ec192d
Compare
Contributor
Author
|
Changes since last push:
|
Collaborator
|
Oh I have another question. Should we fix these tests to a specific Rust version in case rustc changes their error format? |
6ec192d to
f47e84c
Compare
Contributor
Author
|
Changes since last push:
I don't think it's very likely that rustc will change the error messages around these things, since we don't use fancy new features that are likely to change. On the other hand, I don't have enough experience with these things to really know for sure how stable Rust's error messages are. Some points I see are:
So I suggest we don't do any version fixing right now. |
tertsdiepraam
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a proper compile-test framework as suggested in #133 (review):
This basically splits
examples/test_compile_errors_manually.rsinto many testcases that can run automatically. "arguments_file_writeonly" was a bit tricky, since it needs a write-only file, and I don't want to touch on the subject of having to do cleanup after testing.The
*.stderr-files are semi-automatically generated, not hand-crafted, and will need to be updated whenever Rust changes it's error formatting, or whenever we change something about our error messages.Out of scope for this PR:
syn-spans (because I first want to get agreement on how to do the automated tests)