Expose bin_path after parsing#139
Conversation
|
Hi @tertsdiepraam |
|
Hi @tertsdiepraam The bin name is exposed as Additionally, when a user developing with If you have any further concern, I am happy to work on it. 😄 |
tertsdiepraam
left a comment
There was a problem hiding this comment.
Hi! Looks good!
There are some things we should probably think about after this change. Maybe it makes sense to not return a tuple but a struct like this:
struct Parsed<S> {
bin_name: PathBuf,
operands: Vec<OsString>,
settings: S,
}Happy to accept this PR as it is too, but if you agree we can still make that change here.
fea86bd to
fdf3599
Compare
|
Hi, @tertsdiepraam The If there is anything better to have, I am happy to add it into the PR. 😃 |
|
Hi, @tertsdiepraam Does anything need to change in the PR? |
|
After getting rid of a lot of notifications, I found this again. I'm not really involved with the project anymore so I'm gonna defer to the other maintainers (@sylvestre?). But it looks good |
|
Hi @sylvestre If there is anything need to change please let me know. |
fix #137