This repository was archived by the owner on Feb 11, 2026. It is now read-only.
Take positional arguments out of arguments enum#72
Merged
tertsdiepraam merged 1 commit intouutils:mainfrom Dec 19, 2023
Merged
Conversation
359737d to
ac47570
Compare
60a6370 to
ecce4c0
Compare
ecce4c0 to
462898c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70
This is a big change in how positional arguments are handled in this library.
This implements the third option in #70. This means that positional arguments are no longer declared in the
Argumentsenum, but are returned separately from theparsemethod. This allows utils to implement their own handling. This flexibility is necessary and the result is usually not much more verbose than current implementations. What's left to future PRs is to explore how this can become even more convenient.Here's something that's not possible with the behaviour on main (ignoring some error handling):
Before
After