Conversation
woutervanvliet
left a comment
woutervanvliet
left a comment
There was a problem hiding this comment.
Din beskrivelse virker meget lovende, desværre kan jeg ikke køre din projekt.
Mvh,
Wouter
|
|
||
| EXPOSE 3000 | ||
|
|
||
| COPY package.json package.json |
There was a problem hiding this comment.
Mangler der måske også en yarn.lock?
|
|
||
| const dataCached = getState().data[endpoint] | ||
|
|
||
| if (!dataCached || dataCached.length === 0) { |
There was a problem hiding this comment.
Vil det sige at du ikke stoler på cache, hvis den indeholder 0 items?
| if (!dataCached || dataCached.length === 0) { | ||
| dispatch({ type: types.START_LOAD }); | ||
|
|
||
| return loadData('https://swapi.co/api/' + endpoint + '/') |
There was a problem hiding this comment.
Overvej template string
| } | ||
| </p> | ||
| <div className="btn-group"> | ||
| <button disabled={loading} onClick={() => onChooseEndpoint('people')} className={"btn " + (endpoint === 'people' ? 'btn-success' : 'btn-primary')}><i className="fa fa-male"/><i className="fa fa-female"/> Characters</button> |
There was a problem hiding this comment.
Læs evt her hvorfor arrow functions (eller bind) direkte i JSX sjældent er en god ide
https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-bind.md
|
|
||
| COPY . /app | ||
|
|
||
| RUN yarn build |
There was a problem hiding this comment.
Jeg kan ikke bygge din docker image:
Step 7/8 : RUN yarn build
---> Running in 585b63465f34
yarn run v1.13.0
error Command "build" not found.
| dispatch({ type: types.TOGGLE_EXPAND_ITEM, payload: item }); | ||
| }; | ||
|
|
||
| export const onMergeLists = (endpoint) => (dispatch, getState) => { |
There was a problem hiding this comment.
Jeg har lidt svært med at gennemskue meningen med denne action? Og da jeg ikke kan bygge, og dermed heller ikke kan køre, din docker image kan jeg heller ikke se/opleve hvad den gør i browseren.
| } | ||
| <br /> | ||
| {!this.props.data.films || !this.props.data.people | ||
| ? <span>Hint: A secret button will appear when you have seen both the lists of characters and films</span> |
There was a problem hiding this comment.
Lidt sjov hemmelighed, hvis du afslører den med det samme 🤣
| : <span>What do you want to see?</span> | ||
| } | ||
| <br /> | ||
| {!this.props.data.films || !this.props.data.people |
There was a problem hiding this comment.
Jeg kan ikke se at componenten modtage en data prop ud fra PropTypes, er det en forglemmelse eller var det for at holde den hemmelige knap lidt mere hemmeligt.
| ...state, | ||
| data: { | ||
| ...state.data, | ||
| [action.payload]: state.data.films.map(film => ({ ...film, charactersNames: film.characters.map(character => ({ |
There was a problem hiding this comment.
Kan gøres nemmere at læse med lidt linebreaks de rigtige steder.
| COPY package.json package.json | ||
| RUN yarn install | ||
|
|
||
| COPY . /app |
There was a problem hiding this comment.
Hvis jeg allerede har en node_modules liggende, vil den overskrive de node_modules som lige er blevet installeret på linje 8.
|
Jeg havde lavet en forglemmelse - manglede at tilføje build-kommandoen under scripts i package-filen. Det er comittet nu. |
3 participants
My solution for the challenges and some additionally changes: