Conversation
woutervanvliet
suggested changes
Feb 26, 2019
Contributor
woutervanvliet
left a comment
woutervanvliet
left a comment
There was a problem hiding this comment.
Tak for din besvarelse. Prøv evt at se om ikke du kan tilføje en Dockerfile som kan køre din løsning.
Mvh,
Wouter
|
|
||
| export const onExpandItem = (itemId, expanded) => (dispatch) => { | ||
| if (!expanded) { | ||
| dispatch ({ |
Contributor
There was a problem hiding this comment.
Det ville være mere oplagt bare at returnere din action object.
| const mapStateToProps = (state) => { | ||
| const { endpoint, data } = state; | ||
|
|
||
| const { endpoint, data, expandedItems } = state; |
Contributor
There was a problem hiding this comment.
overvej evt at give ItemDisplay ansvar for at hente sin egen expanded status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My take on the Fun with Redux. Finished the first 3 challenges, but also pushed code for an almost complete solution for challenge 4, to give an idea of what i was going for.